1.20.6/1.21.1 support, quiver functionality changed and huge chores #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- minimum mc supported version from 1.16 to 1.17 - removed unused dependencies (findbugs) and use built-in annotations from java 17. Lombok setters/getters are manually implemented instead. - prevent auto ladder from placing more ladders when relative block above/below is air - added versioned util classes for enchantments, potion effect and class types that are missing from slimefun's versioned classes. - mystery sticks now has randomized entity potion effects instead of hardcoding them per stick. - removed unused pdc classes for now - utilize bukkit's util consumer (deprecated) for now to prevent 1.21 java util consumer conflict. - moved consumers out of World#Spawn with same reason as former
- Quiver functionality has been changed to support minimum to max mc versions. Arrows will be drawn from the quiver on player bow shoot. Infinity bows will not auto draw arrows but requires manually adding an arrow to the inventory. Quivers will not work when player is over-encumbered (full inventory), there should be space for arrows being drawn. - huge chores (I do no want to cause headaches for locale maintainers due to these changes but I gotta reduce the cringe with stuffs I wrote years ago)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values