Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation #14

Closed
wants to merge 5 commits into from
Closed

Translation #14

wants to merge 5 commits into from

Conversation

alexey-va
Copy link

@alexey-va alexey-va commented Feb 11, 2024

Changes

  • Added translation via configuration
  • Broken pom and main class a bit (could not compile with dough) so it needs a little tweaking

Not very clean yet

Checklist

  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I have fully tested the proposed changes and promise that they will not break world generation, mob spawning, and the like.

@alexey-va
Copy link
Author

the way you inject sources and trades in lore is a problem though. I personally added config option to disable injecting them at all. Also one can add something like this in translation:

drops-on: "Drops on:"
possible-piglin-reward: "Possible Piglin reward:"

then all thats left is to translate sources and rewards

added config options
@alexey-va
Copy link
Author

More or less ready I think. Also added some useful config options

@FN-FAL113
Copy link
Owner

big pr, could have been segmented nonetheless I appreciate your effort and time for doing the feature and chores. I will check this out from time to time as I am currently busy with life.

@alexey-va
Copy link
Author

alexey-va commented Feb 12, 2024

Broke it into 3 steps:

  • Translating items
  • Translating messages
  • Translating sources/trades

Didn't take much time though, I just wrote proxy classes so that when you create items or use sources/trades they are appended to translation config file. Took like 1-2 hours total. Most lines don't have any logic, only main class needs rework on your part (I broke dough integration cuz couldn't compile with it)

@FN-FAL113
Copy link
Owner

FN-FAL113 commented Feb 12, 2024

Broke it into 3 steps:

  • Translating items
  • Translating messages
  • Translating sources/trades

Didn't take much time though, I just wrote proxy classes so that when you create items or use sources/trades they are appended to translation config file. Took like 1-2 hours total. Most lines don't have any logic, only main class needs rework on your part (I broke dough integration cuz couldn't compile with it)

can you revert back to using dough common and dough updater but only updating the commit hash using recent successful build/s from jitpack dough jitpack. If you're using intellij you can try clearing and invaliding cache. For vscode it will ask to update the classpath. Reason why I use updater and common as I do not use the whole dough-api and at the same time to lessen uber jar size.

trade messages
voider translation
fixed some random NPE in executeTradeMessage
@alexey-va
Copy link
Author

updating to latest build from jitpack solved the issue

@FN-FAL113
Copy link
Owner

There's just small conflict on this caused by the newly merged pr.

@alexey-va alexey-va closed this Feb 24, 2024
@alexey-va alexey-va deleted the merging branch February 24, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants