-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation #14
Translation #14
Conversation
the way you inject sources and trades in lore is a problem though. I personally added config option to disable injecting them at all. Also one can add something like this in translation: drops-on: "Drops on:"
possible-piglin-reward: "Possible Piglin reward:" then all thats left is to translate sources and rewards |
More or less ready I think. Also added some useful config options |
big pr, could have been segmented nonetheless I appreciate your effort and time for doing the feature and chores. I will check this out from time to time as I am currently busy with life. |
Broke it into 3 steps:
Didn't take much time though, I just wrote proxy classes so that when you create items or use sources/trades they are appended to translation config file. Took like 1-2 hours total. Most lines don't have any logic, only main class needs rework on your part (I broke dough integration cuz couldn't compile with it) |
can you revert back to using dough common and dough updater but only updating the commit hash using recent successful build/s from jitpack dough jitpack. If you're using intellij you can try clearing and invaliding cache. For vscode it will ask to update the classpath. Reason why I use updater and common as I do not use the whole dough-api and at the same time to lessen uber jar size. |
trade messages voider translation fixed some random NPE in executeTradeMessage
updating to latest build from jitpack solved the issue |
There's just small conflict on this caused by the newly merged pr. |
Changes
Not very clean yet
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values