-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devcontainer setup #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I can accept it by co-authoring, also donno much about python extensions if are they valid or not.
After pushing my co-authored changes @Mr-Sunglasses please review them and make valid changes
@@ -0,0 +1,19 @@ | |||
{ | |||
"name": "paste.py", | |||
"dockerfile": "Dockerfile", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'dockerfile' key should be nested under 'build' context for clarity with the correct path. Also, 'extensions' is not a valid key at the root level.
"python.linting.mypyEnabled": true, | ||
"python.formatting.provider": "black" | ||
}, | ||
"portsAttributes": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'portsAttributes' is not a valid key. Use 'forwardPorts' to forward ports from the container.
{ | ||
"name": "paste.py", | ||
"dockerfile": "Dockerfile", | ||
"extensions": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'extensions' object format is outdated. Use an array of strings for specifying extension IDs.
#22