Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd : backpressure - Fix to pop items off zebra_announce FIFO for few EVPN triggers (backport #17432) #17437

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 16, 2024

In cases such as 'no advertise-all-vni' and L2 VNI DELETE, we need to pop all the VPN routes present in the bgp_zebra_announce FIFO yet to be processed regardless of VNI is configured or not.

NOTE: NO need to pop the VPN routes in two cases

  1. In free_vni_entry
  • Called by bgp_free()->bgp_evpn_cleanup().
  • Since bgp_delete is called before bgp_free and we pop all the dest pertaining to bgp under delete. 2) evpn_delete_vni() when user configures "no vni" since the withdraw of all routes happen in normal cycle.

Fixes: a07df6f
("bgpd : backpressure - Handle BGP-Zebra(EPVN) Install evt Creation")

Ticket :#4163611


This is an automatic backport of pull request #17432 done by Mergify.

…w EVPN triggers

In cases such as 'no advertise-all-vni' and L2 VNI DELETE, we need to
pop all the VPN routes present in the bgp_zebra_announce FIFO yet to
be processed regardless of VNI is configured or not.

NOTE: NO need to pop the VPN routes in two cases
 1) In free_vni_entry
   - Called by bgp_free()->bgp_evpn_cleanup().
   - Since bgp_delete is called before bgp_free and we pop all the dest
     pertaining to bgp under delete.
 2) evpn_delete_vni() when user configures "no vni" since the withdraw
    of all routes happen in normal cycle.

Fixes: a07df6f
("bgpd : backpressure - Handle BGP-Zebra(EPVN) Install evt Creation")

Ticket :#4163611

Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
(cherry picked from commit 898852f)
@ton31337
Copy link
Member

Let's say for 10.2 to be released before merging this.

@ton31337 ton31337 added freeze Show the warning before merging as failed and removed freeze Show the warning before merging as failed labels Nov 16, 2024
@ton31337 ton31337 merged commit 91f482a into stable/10.2 Nov 19, 2024
19 of 20 checks passed
@ton31337 ton31337 deleted the mergify/bp/stable/10.2/pr-17432 branch November 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants