Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Optimize the way parsing communities if no community alias exists #17457

Conversation

ton31337
Copy link
Member

No description provided.

@frrbot frrbot bot added the bgp label Nov 18, 2024
@ton31337 ton31337 marked this pull request as draft November 18, 2024 21:19
If at least one community alias is configured, then let's do the work,
otherwise we don't need to spend time on splitting stuff and creating
a new string.

This should improve the performance.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337 ton31337 force-pushed the fix/optimize_community_alias_lookup branch from d600a7e to 004d770 Compare November 18, 2024 21:31
@github-actions github-actions bot added size/M and removed size/S labels Nov 18, 2024
@ton31337 ton31337 marked this pull request as ready for review November 19, 2024 08:12
@donaldsharp
Copy link
Member

Not a bad idea.

@donaldsharp donaldsharp merged commit bef0d10 into FRRouting:master Nov 19, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/optimize_community_alias_lookup branch November 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants