bfdd: retain remote dplane client socket #17464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using bfd in remote-dataplane client mode, don't close a new client socket if we're going to try to use it. Signed-off-by: Mark Stapp <mjs@cisco.com>
|
@rzalamena can you take a look at this one? |
rzalamena
approved these changes
Nov 20, 2024
|
Just tried locally with libbfddp sample daemon and it fixes the client mode. |
|
@Mergifyio backport stable/10.2 stable/10.1 |
✅ Backports have been created
|
This was referenced Nov 20, 2024
Jafaral
added a commit
that referenced
this pull request
Nov 21, 2024
bfdd: retain remote dplane client socket (backport #17464)
donaldsharp
added a commit
that referenced
this pull request
Nov 21, 2024
bfdd: retain remote dplane client socket (backport #17464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using bfd in remote-dataplane client mode, don't close a new client socket if we're going to try to use it. It looks to me as if client-mode remote dataplane won't work without something like this?