Bgp bfd and its ilk #17473
Merged
Bgp bfd and its ilk #17473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function when it is run by bgp_start is expected to return a `enum connect_result`. But instead the function returns a variety of values that are not really being checked for. Consolidate to a correct choice. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
a) timers are really large preventing convergence in 30 seconds b) The same configuration does not need to be initiated 60 times when things are not working properly. Once is enough. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
If bgp is coming up and bgp has not received the interface address yet but bgp has knowledge about a bfd peering, allow it to set the peering data appropriately. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
rzalamena
approved these changes
Nov 21, 2024
Jafaral
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) bgp_connect is returning values that are not handled in bgp_fsm.c. Fix this
b) zebra_fec_nexthop_resolution is not using timers that allow for quicker reconvergence in case of a failure on startup
c) bgp is not properly setting up a bfd session when it knows about a bfd peer before it has learned about the interfaces addresses. This is purely a timing issue on startup.