Add error handling in debug files

debug/api.go

@@ -77,7 +77,8 @@ func (h *HandlerT) StopCPUProfile() error {
 	defer h.mu.Unlock()
 	pprof.StopCPUProfile()
 	if h.cpuW == nil {
-		return errors.New("CPU profiling not in progress")
+		//  Profiling was not in progress, so nothing to stop.
+		return nil
 	}
 	log.Info("Done writing CPU profile", "dump", h.cpuFile)
 	if err := h.cpuW.Close(); err != nil {

debug/flags.go

@@ -17,6 +17,7 @@
 package debug
 
 import (
+	"errors"
 	"fmt"
 	"io"
 	"log/slog"
@@ -218,6 +219,11 @@ func StartPProf(address string, withMetrics bool) {
 // Exit stops all running profiles, flushing their output to the
 // respective file.
 func Exit() {
-	Handler.StopCPUProfile()
-	Handler.StopGoTrace()
+	err := errors.Join(
+		Handler.StopCPUProfile(),
+		Handler.StopGoTrace(),
+	)
+	if err != nil {
+		log.Error("Failed to stop profiles", "err", err)
+	}
 }

debug/trace.go

@@ -21,6 +21,7 @@ package debug
 
 import (
 	"errors"
+	"fmt"
 	"os"
 	"runtime/trace"
 
@@ -55,11 +56,12 @@ func (h *HandlerT) StopGoTrace() error {
 	defer h.mu.Unlock()
 	trace.Stop()
 	if h.traceW == nil {
-		return errors.New("trace not in progress")
+		// trace was not running, nothing to stop
+		return nil
 	}
 	log.Info("Done writing Go trace", "dump", h.traceFile)
 	if err := h.traceW.Close(); err != nil {
-		return err
+		return fmt.Errorf("failed to close trace file: %w", err)
 	}
 	h.traceW = nil
 	h.traceFile = ""