Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle every error in test routines #377

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

LuisPH3
Copy link
Contributor

@LuisPH3 LuisPH3 commented Dec 16, 2024

This PR add error handling in unit tests for every test file in the project.
This PR does not change code used anywhere but tests.

Part of: https://github.com/Fantom-foundation/sonic-admin/issues/90

As a rule of thumb: in tests all errors can be checked when t is available.
For utilities where forwarding t is unpractical, a panic would do.
Benchmarks may ignore errors from common utilities for the shake of measuring our code performance only.
The test would fail when returning an error when closing test environment store. The test is rewritten without the suite framework because de-initialization was not working correctly and test cases were abused (combine table test and suite does not work as expected)
Copy link
Contributor

@facuMH facuMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After appropriate testing, this looks good to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants