Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SB3 tutorial (action masking, tests) #1017

Merged
merged 38 commits into from
Jul 11, 2023

Conversation

elliottower
Copy link
Member

@elliottower elliottower commented Jul 7, 2023

Description

This PR does the following:

  • Fix minor issue for macOS (not having __main__)
  • Enabling CI tutorial tests
  • Adding a new tutorial for action masking, and a small file to test that it works with all PettingZoo AEC envs
  • Fixing all usages of RLLib to be the correct stylization, RLlib

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower elliottower changed the title Update SB3 tutorials to run on macOS Update SB3 tutorial (action masking, tests) Jul 8, 2023
@elliottower
Copy link
Member Author

No idea why I'm getting this error in the CI, thinking maybe it's cause the env takes too long to run? But others could do multiple iterations fine. Maybe it's to do with pistonball specifically somehow? The others run fine it seems. Running it locally it takes a minute to run, whereas the other envs can finish in a second.

Using cpu device
Wrapping the env in a VecTransposeImage.
------------------------------
| time/              |       |
|    fps             | 877   |
|    iterations      | 1     |
|    time_elapsed    | 46    |
|    total_timesteps | 40960 |
------------------------------
XIO:  fatal IO error 0 (Success) on X server ":99"
      after 84 requests (84 known processed) with 0 events remaining.
Model has been saved.
XIO:  fatal IO error 0 (Success) on X server ":99"
      after 84 requests (84 known processed) with 0 events remaining.
Error: Process completed with exit code 1.

@elliottower elliottower merged commit a8a8e49 into Farama-Foundation:master Jul 11, 2023
33 checks passed
@elliottower elliottower deleted the sb3-tutorials-update branch July 11, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant