Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded Maze Craze warning #1164

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

dm-ackerman
Copy link
Contributor

Description

Removes the informational warning that Craze Atari env output on init.
The information is clearly stated in the documentation for the env so not
needed as a warning.

Fixes #1158

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Removes the informational warning that Craze Atari env output on init().
The information is clearly stated in the documentation for the env so not
needed as a warning.
@elliottower
Copy link
Member

Ah I see the old pr had some commits from your other changes, cheers

Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjshoots jjshoots merged commit e812151 into Farama-Foundation:master Feb 26, 2024
47 checks passed
@dm-ackerman dm-ackerman deleted the mazecraze_warning branch March 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Misuse of warning in Maze Craze
3 participants