Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agilerl version and simplified CNN definition #1182

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Update agilerl version and simplified CNN definition #1182

merged 5 commits into from
Mar 13, 2024

Conversation

nicku-a
Copy link
Contributor

@nicku-a nicku-a commented Feb 12, 2024

Description

Updates agilerl version in tutorials, and also simplifies kernel size definition for multi-agent CNNs.

Fixes # (issue), Depends on # (pull request)

Type of change

  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nicku-a
Copy link
Contributor Author

nicku-a commented Feb 12, 2024

FYI failing tests correspond to other areas of the codebase (chess test and knights archers zombies docs)

@dm-ackerman
Copy link
Contributor

Hi, I saw the update to AgileRL broke the tutorial a few days ago. Thanks for fixing this! Would you mind updating your branch to the current master? That should fix the broken tests so it can be merged. There will probably be a merge conflict because I pinned the agilerl version to 0.1.19 to stop the errors until the tutorial was fixed. But I think everything else should work fine.

@nicku-a
Copy link
Contributor Author

nicku-a commented Mar 6, 2024

Sorry for the delay @dm-ackerman - should be good to go!

Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Thanks!

@elliottower elliottower merged commit dffd61a into Farama-Foundation:master Mar 13, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants