Enhancement: Better practice when registering commands #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> Considered as bad practice to register commands too frequently so set it as a deploy script
-> It's optionnal use so not using it will default to global status
-> Based on the find_commands, only saves the execute functions in a clear object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discord.js it isn't recommended to register commands when these haven't changed, therefor in this fork it's been changed so that it runs on a user terminal command
npm run deploywhich registers them to the API.Furthermore, I've added a system allowing for global commands and guild only commands giving more flexibility to this boilerplate.
I'm open to any discussion on this PR, thanks for the initial work ;)