change hostname in helpers.tpl and api_enviroment #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitadocker
requested review from
matthewelwell
and removed request for
a team
matthewelwell
requested review from
gagantrivedi
and removed request for
matthewelwell
|
@gagantrivedi can you take a look here please? |
|
@Nikitadocker we are in the process of deprecating influx; you should be able to migrate your data to Postgres once #230 is merged, or you will be able to use external InfluxDB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good afternoon.
I encountered a problem in the form of generating a value for the INFLUXDB_URL variable
This refers to influxdb2 which is included in the helm chart itself. We don't use external ones.
We do not have a standard cluster name.
The problem was that flagsmith-api could not connect to influxdb2
http://flagsmith-new-influxdb2.microservices.svc.kube-main.local:80 we needed this
DNS name
Unfortunately, it was not possible to override the INFLUXDB_URL values for flagsmith-api
Is it possible to add this functionality?
PR shows the changes I made
This helm chart was tested by deployment to the k8s cluster
chart version 0.42.0