-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Version 2.x reintroduce disabling nodes (_hidden=true
)
#55
base: 2.0
Are you sure you want to change the base?
Conversation
With the introduction of subtreetags in Neos9 we could also introduce a 'Flowpack.NodeTemplates:Content.Hidden':
superTypes:
'Neos.Neos:Content': true
options:
template:
disabled: true
# alternative
subtreetags:
disabled: true
properties:
someProperty: "value" |
This reverts commit 4fa4f45.
0f95072
to
9a6933b
Compare
_hidden=true
)
9a6933b
to
4ed8487
Compare
- introduce $showDisabledNodesInSubgraph in tests to show disabled created nodes - introduce `NodeMutator::setDisabled` - updated all snapshots to include `"disabled": false,`
4ed8487
to
c682516
Compare
I started a voting in slack regarding the syntax: option1 1️⃣, first level disabled (no support for custom subtreetags)
option2 2️⃣, nested tags , to also allow custom SubtreeTags in Neos9
option3 3️⃣ , allow both tags and disabled: true first level (basically option1 and option2 combined) we voted with 6 votes for option2 2️⃣ |
…ee tags and allow `tags.disabled` in Neos 8.3
With pr the functionality to set internal node properties via
_foo
property syntax, which was introduced with was reverted. This was done in preparation for the Neos 9 ESCR to be forwards compatible.The most requested internal property
properties._hidden
is now available viatags.disabled
.- The idea of tags is back-ported from Neos 9 where the Node will be tagged as
disabled
or possibly a custom value. See SubtreeTags. Naturally Neos 8.3 can only support the disabled/hidden case and thus other values will throw an exception.- The name shift from
hidden
todisabled
was done to adjust to the naming of the new ESCR. See explanation.This is WIP as the naming of usingThats why this was omitted from the Version2 release but once we find a solution we will release a new version with support for this.hidden
vsdisabled
is not 100% clear yet.Discussion: neos/neos-development-collection#4312
Regarding the naming of the new option
tags
. The term is already partly overloaded and could be mistaken but the reasoning was to align it with the new Neos 9 Api. While more explicit we decided againstsubtreetags
as this term is only used in the cr-write-side and thus more low-level and less know by the integrator. The nametags
as inNode::$tags
(seeNodeTags
) will be part of the Neos 9 API and hopefully a known and understood concept by the user.https://github.com/neos/neos-development-collection/blob/f640f70321f6a96837dbea86ce1d11c72368c924/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php#L128
see also voting: #55 (comment)