Fix incorrect handling of scalar documents with trailing content #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not suitable for use here since the behaviour deviates from the regular document type when it comes to trailing content.
|
Looks good, makes sense. I'll get it merged. |
FourierTransformer
merged commit 8e18887
into
FourierTransformer:master
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #90, I changed the
convert_ondemand_element_to_tableto takedocument_referenceinstead ofdocumentin order to simplify the function signature. However, it turns out the behaviour ofdocument_referencedeviates fromdocumentwhen it comes to handling trailing content after a scalar, see: simdjson/simdjson#2259.I've changed it back to use the
documenttype and added a test to ensure the trailing content is rejected as expected.