non-blocking http requests for Twitch Integration #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
update fork
update fork
…locking aiohttp fetches
|
Awesome! Sorry, I forgot to migrate away from requests when I was finishing the embeds last night. Will get this tested and reviewed. I assume we have a GH issue for the Docker graceful exit? |
we didn't, made one: #62 |
Trimatix
changed the title
|
This can probably be closed as I have made an implementation with the Twitch API on feat/TwitchCog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an untested port of the synchronous requests made by
TwitchIntegrationCogover toaiohttp.I'm not expecting this not to work, but it definitely needs to be tested by @Ryth-cs please, since you know how the cog should work.
You'll notice that there's actually very, very little that's different about the code which is quite nice.
Note that graceful shutdown of the http client on
SIGINT/SIGTERMis set up, we just need to figure out why docker isn't passing the signal to the bot.