-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amend policy insert_acct_class/acct_unique to work with multiple Class attributes #5337
base: v3.2.x
Are you sure you want to change the base?
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
My one question is does this change any existing behavior? If so, it would have to be added as a separate policy. |
Only problem I can foresee is when someone updates to this alternative policy and they have existing old hex encoded So maybe the 'encoder' is good, but for the 'decoder' we need to check if the preamble is either |
Thanks, I'd be happier with being compatible with existing systems. I have a large fear of breaking peoples networks. |
1bc0cd8
to
322ceac
Compare
Sorry it took a while, but I think the functionality to maintain backwards compatibility now works. |
won't let me merge without signed commits. Could you sign these with your GPG key @jimdigriz. Thanks. |
Sorry for the tardiness, cooking a signing key means I have to do some physical gymnastics with USB keys and it has been a busy week. Should be okay now, thanks. |
…th multiple Class attributes We also take the opportunity to remove needless hex encoding for Class attribute (string -> octet)
Some deployments may wish to use multiple
Class
attributes and continue to use FR's existing provided accounting policies.We also take the opportunity to remove needless hex encoding on the
Class
attribute due to the string to octet conversion originally in place; halving their length.