Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend policy insert_acct_class/acct_unique to work with multiple Class attributes #5337

Open
wants to merge 1 commit into
base: v3.2.x
Choose a base branch
from

Conversation

jimdigriz
Copy link
Contributor

@jimdigriz jimdigriz commented Jun 9, 2024

Some deployments may wish to use multiple Class attributes and continue to use FR's existing provided accounting policies.

We also take the opportunity to remove needless hex encoding on the Class attribute due to the string to octet conversion originally in place; halving their length.

@Gman42412

This comment was marked as abuse.

@alandekok
Copy link
Member

My one question is does this change any existing behavior? If so, it would have to be added as a separate policy.

@jimdigriz
Copy link
Contributor Author

jimdigriz commented Jun 11, 2024

Only problem I can foresee is when someone updates to this alternative policy and they have existing old hex encoded Class attributes out there in the wild coming in on the Accounting-Request's.

So maybe the 'encoder' is good, but for the 'decoder' we need to check if the preamble is either hex("ai:") or if it is hex(hex("ai:")) to determine what to do with it.

@alandekok
Copy link
Member

Thanks, I'd be happier with being compatible with existing systems. I have a large fear of breaking peoples networks.

@jimdigriz jimdigriz force-pushed the classy branch 5 times, most recently from 1bc0cd8 to 322ceac Compare June 15, 2024 13:25
@jimdigriz
Copy link
Contributor Author

Sorry it took a while, but I think the functionality to maintain backwards compatibility now works.

@arr2036
Copy link
Member

arr2036 commented Sep 10, 2024

won't let me merge without signed commits. Could you sign these with your GPG key @jimdigriz. Thanks.

@jimdigriz
Copy link
Contributor Author

won't let me merge without signed commits. Could you sign these with your GPG key @jimdigriz. Thanks.

Sorry for the tardiness, cooking a signing key means I have to do some physical gymnastics with USB keys and it has been a busy week.

Should be okay now, thanks.

…th multiple Class attributes

We also take the opportunity to remove needless hex encoding for Class attribute (string -> octet)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants