Merge pull request #22 from FrendsPlatform/issue-20

ExecuteQuery - Changed data type of QueryParameter.Value
FrendsPlatform · Dec 4, 2023 · 093a177 · 093a177
2 parents 7ec6beb + d0cb9f8
commit 093a177
Show file tree

Hide file tree

Showing 12 changed files with 288 additions and 212 deletions.
diff --git a/Frends.MicrosoftSQL.ExecuteQuery/CHANGELOG.md b/Frends.MicrosoftSQL.ExecuteQuery/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.2.0] - 2023-11-30
+### Changed
+- [Breaking] QueryParameter.Value type to object so that binary data can be used.
+
 ## [1.1.0] - 2023-01-27
 ### Changed
 - Naming: Result.QueryResult to Result.Data.

diff --git a/Frends.MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/AutoUnitTests.cs b/Frends.MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/AutoUnitTests.cs
@@ -9,7 +9,7 @@ namespace Frends.MicrosoftSQL.ExecuteQuery.Tests;
 public class AutoUnitTests
 {
     /*
-        docker-compose up
+        docker-compose up -d
 
         How to use via terminal:
         docker exec -it sql1 "bash"
@@ -20,7 +20,7 @@ docker exec -it sql1 "bash"
 
     private static readonly string _connString = "Server=127.0.0.1,1433;Database=Master;User Id=SA;Password=Salakala123!";
     private static readonly string _tableName = "TestTable";
-    
+
     [TestInitialize]
     public void Init()
     {

diff --git a/...ds.MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/ExceptionUnitTests.cs b/...ds.MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/ExceptionUnitTests.cs
@@ -19,7 +19,7 @@ docker exec -it sql1 "bash"
 
     private static readonly string _connString = "Server=127.0.0.1,1433;Database=Master;User Id=SA;Password=Salakala123!";
     private static readonly string _tableName = "TestTable";
-    
+
     [TestInitialize]
     public void Init()
     {
@@ -83,4 +83,47 @@ public async Task TestExecuteQuery_Invalid_Creds_ReturnErrorMessage()
         Assert.IsTrue(result.ErrorMessage.Contains("Login failed for user 'SA'."));
         Assert.AreEqual(0, result.RecordsAffected);
     }
+
+    [TestMethod]
+    public void TestExecuteQuery_ExceptionIsThrownWhenQueryFails()
+    {
+        var input = new Input()
+        {
+            Query = $"INSERT INTO {_tableName} VALUES (1, Unit, Tests, 456)",
+            ExecuteType = ExecuteTypes.NonQuery,
+            ConnectionString = _connString,
+        };
+
+        var options = new Options()
+        {
+            SqlTransactionIsolationLevel = SqlTransactionIsolationLevel.ReadCommitted,
+            CommandTimeoutSeconds = 2,
+            ThrowErrorOnFailure = true
+        };
+
+        var ex = Assert.ThrowsExceptionAsync<Exception>(async () => await MicrosoftSQL.ExecuteQuery(input, options, default));
+        Assert.IsTrue(ex.Result.Message.Contains("System.Data.SqlClient.SqlException (0x80131904): Invalid column name 'Unit'."));
+    }
+
+    [TestMethod]
+    public async Task TestExecuteQuery_ErrorMessageWhenQueryFails()
+    {
+        var input = new Input()
+        {
+            Query = $"INSERT INTO {_tableName} VALUES (1, Unit, Tests, 456)",
+            ExecuteType = ExecuteTypes.NonQuery,
+            ConnectionString = _connString,
+        };
+
+        var options = new Options()
+        {
+            SqlTransactionIsolationLevel = SqlTransactionIsolationLevel.ReadCommitted,
+            CommandTimeoutSeconds = 2,
+            ThrowErrorOnFailure = false
+        };
+
+        var result = await MicrosoftSQL.ExecuteQuery(input, options, default);
+        Assert.IsFalse(result.Success);
+        Assert.IsTrue(result.ErrorMessage.Contains("System.Data.SqlClient.SqlException (0x80131904): Invalid column name 'Unit'."));
+    }
 }