Add "Disable fine-grained caching" checker (#282)

* Add "Disable fine-grained caching" checker * Add cache tagging config fallback
FriendsOfShopware · Nov 11, 2024 · 06ec204 · 06ec204
1 parent 8bb38e9
commit 06ec204
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 0 deletions.
diff --git a/src/Components/Health/Checker/PerformanceChecker/FineGrainedCachingChecker.php b/src/Components/Health/Checker/PerformanceChecker/FineGrainedCachingChecker.php
@@ -0,0 +1,44 @@
+<?php
+
+namespace Frosh\Tools\Components\Health\Checker\PerformanceChecker;
+
+use Frosh\Tools\Components\Health\Checker\CheckerInterface;
+use Frosh\Tools\Components\Health\HealthCollection;
+use Frosh\Tools\Components\Health\SettingsResult;
+use Symfony\Component\DependencyInjection\Attribute\Autowire;
+
+class FineGrainedCachingChecker implements PerformanceCheckerInterface, CheckerInterface
+{
+    public const DOCUMENTATION_URL = 'https://developer.shopware.com/docs/guides/hosting/performance/performance-tweaks.html#disable-fine-grained-caching';
+
+    public function __construct(
+        #[Autowire('%kernel.shopware_version%')]
+        public readonly string $shopwareVersion,
+        #[Autowire('%shopware.cache.tagging.each_config%')]
+        public readonly bool $cacheTaggingEachConfig,
+        #[Autowire('%shopware.cache.tagging.each_snippet%')]
+        public readonly bool $cacheTaggingEachSnippet,
+        #[Autowire('%shopware.cache.tagging.each_theme_config%')]
+        public readonly bool $cacheTaggingEachThemeConfig,
+    ) {}
+
+    public function collect(HealthCollection $collection): void
+    {
+        if (\version_compare('6.5.4.0', $this->shopwareVersion, '>')) {
+            return;
+        }
+
+        if ($this->cacheTaggingEachConfig || $this->cacheTaggingEachSnippet || $this->cacheTaggingEachThemeConfig) {
+            $collection->add(
+                // only info, because it only affects redis, varnish etc.
+                SettingsResult::info(
+                    'fine-grained-caching',
+                    'Fine-grained caching on Redis, Varnish etc.',
+                    'enabled',
+                    'disabled',
+                    self::DOCUMENTATION_URL,
+                ),
+            );
+        }
+    }
+}
diff --git a/src/DependencyInjection/SymfonyConfigCompilerPass.php b/src/DependencyInjection/SymfonyConfigCompilerPass.php
@@ -31,5 +31,17 @@ public function process(ContainerBuilder $container): void
         if (!$container->hasParameter('shopware.cart.compression_method')) {
             $container->setParameter('shopware.cart.compression_method', false);
         }
+
+        if (!$container->hasParameter('shopware.cache.tagging.each_config')) {
+            $container->setParameter('shopware.cache.tagging.each_config', true);
+        }
+
+        if (!$container->hasParameter('shopware.cache.tagging.each_snippet')) {
+            $container->setParameter('shopware.cache.tagging.each_snippet', true);
+        }
+
+        if (!$container->hasParameter('shopware.cache.tagging.each_theme_config')) {
+            $container->setParameter('shopware.cache.tagging.each_theme_config', true);
+        }
     }
 }