Fix crash causing grid view to completely stop working #250
Conversation
This doesn't delve any deeper in to the issue, but it fixes the immediate problem. Tested this locally and grid view seems OK, but I've not exhaustively tested all features.
|
I don't think anyone else has write permissions on the repo (and even worse, in the Google store) except @Fugiman (which is not a great bus factor). |
|
Yeah, I noticed very simple PRs have been open for days. At least people can still use this without it being released, it's just more of a hassle. I posted some instructions here. |
|
Thank you for the workaround. It worked fine on Chrome for MacOS as well. |
|
I'm helping a summer camp run virtually, and this extension has been vital to class engagement and monitoring. But I can't ask 20 music teachers to do this workaround. @Fugiman Thanks for all your hard work! Please pull and/or add a co-writer, we (and I'm sure others) are relying on this software now! |
|
This seemed effective for me as well all day today. Windows 10 2004 / Chrome Beta 84.0.4147.68 / ViolentMonkey 2.12.7 Due to it leaking memory previously until it filled all physical mem, I had the Dev Console open ahead of time, as well as Process Explorer watching the performance graphs for the Meet window Chrome process. Initially the Meet window started chewing through a LOT of RAM, climbing several megs a second over 10-15 minutes to close to 2GB total for that tab alone, which made me worried initially, but system was only at ~16GB out of 24GB physical memory used so I let it ride. After a bit, it dropped down to ~1.2G, but still was climbing and only took a few minutes to pass 1.45GB again, before dropping down to 1.2 again. It did that a couple times, and I figured some kind of garbage collection was keeping it in check, so left it on. A short bit later, the tab seemingly randomly dropped WAY down in mem usage to only ~320MB-370MB, and then stayed there the entire rest of the day with Grid View enabled the whole time. Nothing of note had changed, number of users stayed at 3-6, with multiple people leaving and rejoining throughout the day, and had someone start a presentation just to test if that caused any issues, but everything continued to work the rest of the day without issue or memory usage going back up.
|
|
This worked @thor84no |
|
This worked for me! Ubuntu 20.04 |
|
This worked(Mac OS Catalina, Brave version 1.10.97), thank you so much @thor84no |
This doesn't delve any deeper in to the issue, but it fixes the immediate problem. Tested this locally and grid view seems OK, but I've not exhaustively tested all features.
By submitting this Contribution you hereby grant to Chris Gamble a worldwide, royalty-free, non-exclusive, perpetual and irrevocable license, with the right to transfer an unlimited number of non-exclusive licenses or to grant sublicenses to third parties, under the Copyright covering the Contribution to use the Contribution by all means, including, but not limited to: publish the Contribution, modify the Contribution, prepare derivative works based upon or containing the Contribution and/or to combine the Contribution with other Materials, reproduce the Contribution in original or modified form, distribute, to make the Contribution available to the public, display and publicly perform the Contribution in original or modified form.