Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Testing and adjustments #1386

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Aug 15, 2024

PR to add documentation for AWS logging.

After testing with the right values for each environment variable required by both the backend and AWS S3, it turns out we don't need to make any changes. I added a guide with the variables and example values.

Changelog

  • Added documentation on how to get FML to work with AWS S3
  • Set UsePathStyle property to false in order to get AWS S3 to track correctly (otherwise the resource cannot be found)

@jescalada jescalada self-assigned this Aug 15, 2024
@jescalada jescalada marked this pull request as ready for review August 15, 2024 01:50
docs/aws_s3_tracking.md Outdated Show resolved Hide resolved
@jescalada
Copy link
Collaborator Author

After testing once again the whole flow with proper values for the URIs and AWS params, everything seems to work fine even when omitting the path style. I am a bit confused as to why it wasn't quite working before. 🤔

Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc only :-)

@jescalada jescalada merged commit 62bc122 into G-Research:main Aug 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants