Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping pydantic >= 2.0.0 #247

Merged
merged 15 commits into from
Jun 13, 2024
Merged

Bumping pydantic >= 2.0.0 #247

merged 15 commits into from
Jun 13, 2024

Conversation

jannisborn
Copy link
Contributor

@jannisborn jannisborn commented Jun 10, 2024

Problem:

  • HF Spaces apps are getting down due to deprecated gradio version
  • Compliant gradio version relies on pydantic 2.*
  • GT4SD relies on pydantic 1.*

--> Goal: Bump pydantic

Refactor is largely done but not all tests are passing yet.

Without the hacky line

            VanillaConfiguration.__pydantic_validator__ = True  # type: ignore

we get:

TypeError: Parameter list to Generic[...] cannot be empty

It would be best to find a way to have a non-empty parameter list here.

@cla-bot cla-bot bot added the cla-signed CLA has been signed label Jun 10, 2024
Copy link

cla-bot bot commented Jun 10, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: fiskrt.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed CLA has been signed label Jun 10, 2024
@cla-bot cla-bot bot added the cla-signed CLA has been signed label Jun 10, 2024
@fiskrt fiskrt force-pushed the pydantic_bump branch 2 times, most recently from dfd667f to 241fbf8 Compare June 11, 2024 10:50
Copy link
Contributor

@drugilsberg drugilsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, few comments.

dev_requirements.txt Outdated Show resolved Hide resolved
src/gt4sd/configuration.py Outdated Show resolved Hide resolved
@drugilsberg drugilsberg self-requested a review June 12, 2024 11:37
@jannisborn jannisborn marked this pull request as ready for review June 12, 2024 13:40
@fiskrt
Copy link
Contributor

fiskrt commented Jun 13, 2024

Can we merge?

Copy link
Contributor

@drugilsberg drugilsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fiskrt fiskrt merged commit 7dc926d into main Jun 13, 2024
4 checks passed
@jannisborn jannisborn deleted the pydantic_bump branch June 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants