Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create loading screen and halfscreen #131

Merged
merged 4 commits into from
Sep 11, 2024
Merged

create loading screen and halfscreen #131

merged 4 commits into from
Sep 11, 2024

Conversation

ivanwangg
Copy link
Contributor

@ivanwangg ivanwangg commented Sep 9, 2024 •
edited
Loading

No description provided.

@ivanwangg ivanwangg changed the title create loading screen create loading screen and halfscreen Sep 9, 2024
parkerra
parkerra requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@parkerra parkerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the components look great! They worked really well when I ran it on my phone too. I left a few small comments about the code and using an SVG instead of a PNG for the logo, but other than that it looks good!

web/public/MBBLogo.png Outdated Show resolved Hide resolved
web/components/logos/Loading.tsx Outdated Show resolved Hide resolved
web/components/logos/Loading.tsx Outdated Show resolved Hide resolved
web/components/logos/HalfScreen.tsx Outdated Show resolved Hide resolved
web/components/logos/HalfScreen.tsx Outdated Show resolved Hide resolved
@parkerra parkerra self-requested a review September 11, 2024 01:55
@parkerra parkerra merged commit 2f97ef8 into main Sep 11, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkerra parkerra parkerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanwangg @parkerra