Onboarding Part 1 #134
Merged
Onboarding Part 1 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for motherhoodbeyondbars ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
parkerra
requested changes
Sep 15, 2024
| </span> | ||
| </div> | ||
| <div className="flex flex-col p-7 gap-[1.125rem]"> | ||
| <h1 className="text-primary-text text-2xl font-bold font-opensans"> |
There was a problem hiding this comment.
The titles for Desktop views should be centered on the page using sm:
web/components/atoms/ProgressBar.tsx
Outdated
| @@ -5,7 +5,7 @@ interface Props { | |||
|
|
|||
| export default function ProgressBar({ progress }: Props) { | |||
| return ( | |||
| <div className="h-[6px] relative rounded-full bg-empty-gray"> | |||
| <div className="h-[6px] w-[107px] lg:w-[250px] relative rounded-full bg-empty-gray"> | |||
There was a problem hiding this comment.
The progress bar looks SO GOOD especially the animation between pages :D The widths should be relative precents though for desktop vs mobile using sm instead of set sizes so that it adjusts better to different screen sizes
parkerra
requested changes
Sep 16, 2024
| </div> | ||
| <CheckboxText label="I agree to the Liability Waiver" /> | ||
| <div className="mt-3"> | ||
| <TextInput label="Signature" /> |
There was a problem hiding this comment.
This page is missing error checking 😅 The user should agree to the waiver and sign it with the date before moving on
…OfGood/motherhood-beyond-bars into 122-isaiah-onboarding-pt1
…ond-bars into 122-isaiah-onboarding-pt1
parkerra
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request change?
Creates to form for onboarding waiver, shipping address, and contact preference. Also creates a lot of the general infrastructure for onboarding. Closes #122
Important Changes
Important Notes
I'm not sure how we want to handle the waiver in the form, so could use some guidance on that. Also still working on completing the form sorry about that 😅