New api for html file

[MathieuCarriere]

Branch to be merged after keplermapper PR of gudhi has been merged

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

VincentRouvreau commented on 2024-01-24T09:25:09Z
----------------------------------------------------------------

Line #4.        voronoi_samples=100, verbose=True)

It seems to me you are using the verbosity more for debug purposes than for interesting information for the user, no ?

If this is the case, I think we could have a global variable verbose at the beginning of the notebook, False by default, and that could be changed for the entire notebook:

python

verbose = False # set it to True for debug information

...

cover_complex = GraphInducedComplex(..., verbose=verbose)

...

cover_complex = MapperComplex(..., verbose=verbose)

...

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

VincentRouvreau commented on 2024-01-24T09:25:10Z
----------------------------------------------------------------

Line #1.    cover_complex = MapperComplex(

This is the new cover complex interfaces that requires gudhi 3.9.0.

In

TDA-tutorial/.binder/requirements.txt

Line 11 in c35dfff

gudhi!=3.7.0 # cf. https://github.com/GUDHI/TDA-tutorial/issues/65

you should change this line with:

gudhi>=3.9.0

[MathieuCarriere]

Thanks @VincentRouvreau, I agree with your comments, I've just implemented them