Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlphaDTMFiltration was failing with duplicated points #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VincentRouvreau
Copy link
Contributor

Ordering changes in 3d is no longer the behaviour

Fix #72

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mglisse
Copy link
Member

mglisse commented Mar 1, 2024

Did you check manually on an example (without duplicated points) that it gives exactly the same filtration as before? Ok if it does.

@VincentRouvreau
Copy link
Contributor Author

Did you check manually on an example (without duplicated points) that it gives exactly the same filtration as before? Ok if it does.

Yes, the returned simplex trees are the same for AlphaDTMFiltration() if Y = X or Y = np.array([alpha_complex.get_point(i) for i in range(N_tot)])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants