Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fromsocket to deal with ipv6 socket #2497

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

leommxj
Copy link
Contributor

@leommxj leommxj commented Oct 28, 2024

For AF_INET6 address family, getpeername will return a four-tuple, and throw exception. we only need the first two.

@peace-maker
Copy link
Member

Good catch, can you add this under a new 4.13.2 section in the CHANGELOG please?
Bonus points for tests for the fromsocket function! 😏

@leommxj
Copy link
Contributor Author

leommxj commented Oct 29, 2024

try to use Cloudflare's DNS server to test fromsocket, but looks like github action runner are not necessarily have ipv6 address

@peace-maker
Copy link
Member

Thank you, we can try some local IP if ipv6 is enabled at all on the runners

@peace-maker peace-maker enabled auto-merge (squash) November 1, 2024 12:13
@peace-maker peace-maker merged commit 96d98cf into Gallopsled:stable Nov 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants