Fixed the situation where the current local ini is newer than the distributed one + performance increase #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso fixed performance hit when checking for update
…lso fixed performance hit when checking for update
Conflicts: src/phpbrowscap/Browscap.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for updated ini, the current version touches local ini's that are newer than the remote ini, making it even newer, fixed this never ending condition where update doesn't seem to be needed due to local being newer. In this fork the local ini will get stale eventually. (I pull projects from remote repo's and some of them have an old browscap.ini inside but get the current date as creation date).
Also the cache doesn't have to be rewritten always when checking for update. fixed in this fork.