Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NC Sun Bucks #654

Merged
merged 12 commits into from
Dec 13, 2024
Merged

Add NC Sun Bucks #654

merged 12 commits into from
Dec 13, 2024

Conversation

msrezaie
Copy link
Collaborator

@msrezaie msrezaie commented Dec 2, 2024 •
edited
Loading

What (if any) features are you implementing?

  • Added a new program calculator for NC specific program Sun Bucks.
  • Added a new field has_sunbucks in the Screener model to show that a screen has the Sun Bucks benefit.

Any other comments, questions, or concerns?

  • In order to make use of this program, it must first be added through the Translations Admin with the abbreviated_name of sunbucks.
  • Run python manage.py migrate to add the new model changes.

@msrezaie msrezaie linked an issue Dec 2, 2024 that may be closed by this pull request
Add Sun Bucks program #644
Open
@msrezaie msrezaie marked this pull request as ready for review December 2, 2024 18:12
CalebPena
CalebPena approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@CalebPena CalebPena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left on optional suggestion.

programs/programs/nc/sun_bucks/calculator.py Outdated Show resolved Hide resolved
CalebPena
CalebPena requested changes Dec 3, 2024
View reviewed changes
screener/models.py Outdated Show resolved Hide resolved
@msrezaie msrezaie mentioned this pull request Dec 4, 2024
Merged
@CalebPena CalebPena merged commit 4e714bb into dev Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebPena CalebPena CalebPena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sun Bucks program
2 participants
@msrezaie @CalebPena