Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency image refactor #634

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Dependency image refactor #634

wants to merge 9 commits into from

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Nov 4, 2024

Summary

Test whether we can omit one dependency image. This is required to run our unit tests in debug mode, which is advised.

PR Checklist

  • All necessary documentation has been adapted or there is an issue to do so.
  • The implemented feature is covered by an appropriate test.

@Taepper Taepper force-pushed the dependency-image branch 2 times, most recently from e740797 to 3619091 Compare November 13, 2024 16:28
@Taepper Taepper marked this pull request as ready for review November 14, 2024 16:11
Copy link
Contributor

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.4.0 (2024-11-14)

⚠ BREAKING CHANGES

  • metadataInputFile key in preprocessing config file has been removed. Instead, ndjson files should be used and specified with the ndjsonInputFilename option

Features

Bug Fixes

  • preprocessing: correct error message when field is in config but not in metadata file (828182a)
  • remove shared_ptr in lambda captures which might lead to memory leaks (a26d8b8)

@Taepper Taepper marked this pull request as draft November 14, 2024 16:12
@Taepper Taepper force-pushed the dependency-image branch 3 times, most recently from ce0ca20 to 79ed659 Compare November 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant