-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/Gallery example "Cross-section along a transect": General improvements #3623
Open
yvonnefroehlich
wants to merge
12
commits into
main
Choose a base branch
from
use-list-example-profil
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
documentation
Improvements or additions to documentation
skip-changelog
Skip adding Pull Request to changelog
labels
Nov 17, 2024
yvonnefroehlich
changed the title
DOC/Gallery example "Cross-section along a transect": Use list for "center" and "endpoint" parameters
DOC/Gallery example "Cross-section along a transect": Use lists for "center" and "endpoint" parameters
Nov 17, 2024
yvonnefroehlich
changed the title
DOC/Gallery example "Cross-section along a transect": Use lists for "center" and "endpoint" parameters
DOC/Gallery example "Cross-section along a transect": Minor code improvements
Nov 17, 2024
The changes look good to me. Could you please also rewrap the lines to <88 characters? |
seisman
reviewed
Nov 17, 2024
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
yvonnefroehlich
changed the title
DOC/Gallery example "Cross-section along a transect": Minor code improvements
DOC/Gallery example "Cross-section along a transect": General improvements
Nov 17, 2024
seisman
reviewed
Nov 17, 2024
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
yvonnefroehlich
added
the
maintenance
Boring but important stuff for the core devs
label
Nov 18, 2024
seisman
approved these changes
Nov 19, 2024
seisman
added
the
final review call
This PR requires final review and approval from a second reviewer
label
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
final review call
This PR requires final review and approval from a second reviewer
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR contains general improvements of the Gallery example "Cross-section along a transect":
center
andendpoint
parametersxshift
flexiblePreview: https://pygmt-dev--3623.org.readthedocs.build/en/3623/gallery/images/cross_section.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code