Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Gleam 1.3 JS fixes to Nix #13

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Port Gleam 1.3 JS fixes to Nix #13

merged 4 commits into from
Jul 28, 2024

Conversation

PgBiel
Copy link
Member

@PgBiel PgBiel commented Jul 28, 2024

Ports the following JS target fixes to Nix:

  1. Adds bit array byte-alignment compile-time checks (Try to compile time error when trying to make non byte aligned array on js gleam-lang/gleam#3111)
  2. Do not unnecessarily rewrite gleam.nix in the build output (from the fix to gleam build generates gleam.mjs and gleam.d.mts even if they already exist gleam-lang/gleam#3178 at gleam-lang/gleam@9755365)
  3. Fix using aliased record constructors in constants (from the fix for Imports renamed with as then used in consts generate invalid JavaScript code gleam-lang/gleam#3294 at gleam-lang/gleam@ec614e7)

Also added a test to verify that gleam-lang/gleam#3379 does not apply to the Nix target.

@PgBiel PgBiel added bug Something isn't working enhancement New feature or request labels Jul 28, 2024
@PgBiel PgBiel added this to the v0.3.0 milestone Jul 28, 2024
@PgBiel PgBiel merged commit 31840e2 into main Jul 28, 2024
17 checks passed
@PgBiel PgBiel deleted the add-130-stuff-to-nix branch July 28, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant