Fire PlayerInitialSpawnEvent (#922) (#1051)

* No longer fire PlayerInitialSpawnEvent in GlowPlayer

It will be fired in player-specific code in GlowEntity, instead.

* Fire PlayerInitialSpawnEvent in GlowEntity

This way, it is ordered correctly with other event calls.

* Fix setting events' world not affecting player

src/main/java/net/glowstone/entity/GlowEntity.java

@@ -2,6 +2,7 @@
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import com.destroystokyo.paper.event.player.PlayerInitialSpawnEvent;
 import com.flowpowered.network.Message;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
@@ -310,19 +311,31 @@ public boolean isInvulnerable() {
      * @param location The location of the entity.
      */
     public GlowEntity(Location location) {
+        // Set initial locations for events.
         this.origin = location.clone();
         this.previousLocation = location.clone();
         this.location = location.clone();
 
-        world = (GlowWorld) location.getWorld();
-        server = world.getServer();
         // this is so dirty I washed my hands after writing it.
         if (this instanceof GlowPlayer) {
-            // spawn location event
+            // initial spawn event, first
+            location = EventFactory.getInstance()
+                .callEvent(new PlayerInitialSpawnEvent((Player) this, location))
+                .getSpawnLocation();
+
+            // then, spawn location event (with location updated from initial spawn event)
             location = EventFactory.getInstance()
                 .callEvent(new PlayerSpawnLocationEvent((Player) this, location))
                 .getSpawnLocation();
+
+            // Update from modifications done on events.
+            Position.copyLocation(location, this.origin);
+            Position.copyLocation(location, this.previousLocation);
+            Position.copyLocation(location, this.location);
         }
+        world = (GlowWorld) location.getWorld();
+        server = world.getServer();
+
         server.getEntityIdManager().allocate(this);
         world.getEntityManager().register(this);
     }