lets avoid text cuz fonts

GoogleChrome · Aug 1, 2023 · 12786db · 12786db
1 parent 3134867
commit 12786db
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 17 deletions.
diff --git a/cli/test/fixtures/screenshot-nodes.html b/cli/test/fixtures/screenshot-nodes.html
@@ -18,6 +18,7 @@
       margin: 10px;
       padding: 5px;
     }
+    /* Want a LCP, but not any image or text visible! */
     img {
       opacity: 0.001;
     }
@@ -35,7 +36,7 @@
 </head>
 
 <body>
-  <p id="textEl">Screenshot tester 2</p>
+  <p id="textEl"></p>
 
   <script>
     const params = new URLSearchParams(document.location.search);

diff --git a/core/test/gather/gatherers/full-page-screenshot-test.js b/core/test/gather/gatherers/full-page-screenshot-test.js
@@ -316,6 +316,9 @@ describe('FullPageScreenshot gatherer', () => {
           if (!(node.id.includes('green') || node.id.includes('red'))) {
             continue;
           }
+          if (!node.id.includes('el-')) {
+            continue;
+          }
 
           const expectedColor = hexToRgb(node.id.includes('green') ? '#427f36' : '#8a4343');
           const result = {id: node.id, success: true};
@@ -430,15 +433,15 @@ describe('FullPageScreenshot gatherer', () => {
       const rectExpectations = [
         {
           id: 'el-1-red',
-          top: 43,
-          bottom: 53,
+          top: 10,
+          bottom: 20,
           left: 18,
           right: 178,
         },
         {
           id: 'el-2-green',
-          top: 93,
-          bottom: 153,
+          top: 60,
+          bottom: 120,
           left: 48,
           right: 108,
         },
@@ -456,15 +459,15 @@ describe('FullPageScreenshot gatherer', () => {
       const rectExpectations = [
         {
           id: 'el-1-red',
-          top: 61,
-          bottom: 71,
+          top: 10,
+          bottom: 20,
           left: 18,
           right: 178,
         },
         {
           id: 'el-2-green',
-          top: 111,
-          bottom: 171,
+          top: 60,
+          bottom: 120,
           left: 48,
           right: 108,
         },
@@ -482,15 +485,15 @@ describe('FullPageScreenshot gatherer', () => {
       const rectExpectations = [
         {
           id: 'el-1-red',
-          top: 43,
-          bottom: 53,
+          top: 10,
+          bottom: 20,
           left: 18,
           right: 178,
         },
         {
           id: 'el-2-green',
-          top: 93,
-          bottom: 153,
+          top: 60,
+          bottom: 120,
           left: 48,
           right: 108,
         },
@@ -508,15 +511,15 @@ describe('FullPageScreenshot gatherer', () => {
       const rectExpectations = [
         {
           id: 'el-1-red',
-          top: 43,
-          bottom: 53,
+          top: 10,
+          bottom: 20,
           left: 18,
           right: 178,
         },
         {
           id: 'el-2-green',
-          top: 93,
-          bottom: 153,
+          top: 60,
+          bottom: 120,
           left: 48,
           right: 108,
         },