Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: leverage job dependencies #10994

Closed
wants to merge 6 commits into from
Closed

tests: leverage job dependencies #10994

wants to merge 6 commits into from

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Jun 18, 2020

(This is a PR against #10988)

I mentioned this a while ago but you can use job.needs plus uploading/downloading artifacts to handle file dependencies between jobs: treosh/lighthouse-ci-action#40

so here's the setup:

  • build job
    • test job
  • smoke job

the diff is kinda useless but f1b68c4 has real meat of it.


on #10993:

  1. the removal of yarn cache wfm. i wasn't ever too impressed with it. so i copied that here.
  2. the smoke splitting is dope. didnt carry into this branch but we'll sort that out tomorrrow.

@connorjclark
Copy link
Collaborator

+1 to the semantical split of build + test. I had this during my iterations. I ended up removing it because there aren't a lot of actual dependencies in test on the dist/ artifact, so making the test job dependent on build 1) blurs what parts actually require build artifacts and 2) makes the test job take longer to start, finish, esp steps that 100% have no data dependency (lint, typecheck).

@paulirish
Copy link
Member Author

yeah. all true.

and given that build-all is relatively fast.. i think it's the right call to make any child jobs depend on it.

okay great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants