Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add dependabot.yml #15341

Merged
merged 3 commits into from
Aug 10, 2023
Merged

misc: add dependabot.yml #15341

merged 3 commits into from
Aug 10, 2023

Conversation

connorjclark
Copy link
Collaborator

See https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

There is no way to exclude certain subfolders (like legacy-javascript package.json). See dependabot/dependabot-core#4364 . But we could at least move all those deps into devDeps which should exclude them from updates.

@connorjclark connorjclark requested a review from a team as a code owner August 3, 2023 19:42
@connorjclark connorjclark requested review from adamraine and removed request for a team August 3, 2023 19:42
@adamraine
Copy link
Member

Should we do the same for other random package.json? e.g.: https://github.com/GoogleChrome/lighthouse/blob/main/docs/recipes/auth/package.json

@connorjclark
Copy link
Collaborator Author

No, those are arguably security sensitive (we tell people to use them as examples) so should get updates.

@brendankenny
Copy link
Member

"security"

@adamraine
Copy link
Member

No, those are arguably security sensitive (we tell people to use them as examples) so should get updates.

Then should we change the docs ones that use devDependencies
https://github.com/GoogleChrome/lighthouse/blob/main/docs/recipes/type-checking/package.json
https://github.com/GoogleChrome/lighthouse/blob/main/docs/recipes/lighthouse-plugin-example/package.json

@connorjclark
Copy link
Collaborator Author

Idk, let's not overfit this thing and just continue to use what we thought best for these examples

@@ -1,7 +1,7 @@
{
"private": true,
"type": "module",
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@connorjclark connorjclark merged commit eb877a1 into main Aug 10, 2023
27 checks passed
@connorjclark connorjclark deleted the depbodyml branch August 10, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants