Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(sentry): upgrade to v7 #16215

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 8, 2024

Summary

The current version of @sentry/node brings in a vulnerable version of the cookie package (GHSA-pxg6-pf52-xh8x), which is not present in v7.

This should be an easy bump as v7 was mainly about changes to the internals of Sentry so has a very small upgrade path: https://docs.sentry.io/platforms/javascript/migration/v6-to-v7/

Note that the latest is v8 but that has a lot more breaking changes in the public interface: https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/

Related Issues/PRs

Relates to #16131

@G-Rath G-Rath requested a review from a team as a code owner October 8, 2024 23:06
@G-Rath G-Rath requested review from adamraine and removed request for a team October 8, 2024 23:06
@G-Rath G-Rath changed the title feat: upgrade @sentry/node to v7 deps: upgrade @sentry/node to v7 Oct 8, 2024
@G-Rath

This comment was marked as resolved.

G-Rath added a commit to ackama/nzsl-share that referenced this pull request Oct 15, 2024
We're currently blocked on patching this by
GoogleChrome/lighthouse#16215
@connorjclark connorjclark requested review from connorjclark and removed request for adamraine October 15, 2024 22:32
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade!

@connorjclark connorjclark changed the title deps: upgrade @sentry/node to v7 deps(sentry): upgrade to 7.119.1 Oct 15, 2024
@connorjclark connorjclark changed the title deps(sentry): upgrade to 7.119.1 deps(sentry): upgrade to 7 Oct 15, 2024
@connorjclark connorjclark changed the title deps(sentry): upgrade to 7 deps(sentry): upgrade to v7 Oct 15, 2024
@connorjclark connorjclark merged commit 6ff3ef0 into GoogleChrome:main Oct 15, 2024
24 checks passed
@G-Rath G-Rath deleted the upgrade-sentry branch October 15, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants