Skip to content

Commit

Permalink
fix release staging (#1992)
Browse files Browse the repository at this point in the history
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
  • Loading branch information
Polber authored Nov 6, 2024
1 parent 15609c3 commit 4675f9d
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ private void stageXlangUsingDockerfile(String imagePath, String containerName)
directory,
cloudBuildLogs);

// Ideally this should raise an exception, but in GitHub Actions this returns NZE even for
// Ideally this should raise an exception, but this returns NZE even for
// successful runs.
if (stageProcess.waitFor() != 0) {
LOG.warn(
Expand Down Expand Up @@ -1263,9 +1263,10 @@ private static void performVulnerabilityScanAndGenerateUserSBOM(
buildDir,
cloudBuildLogs);

// Ideally this should raise an exception, but this returns NZE even for
// successful runs.
if (stageProcess.waitFor() != 0) {
throw new IllegalStateException(
"Error scanning container. Check logs for details. " + cloudBuildLogs);
LOG.warn("Error scanning container. Check logs for details. " + cloudBuildLogs);
}
}

Expand Down

0 comments on commit 4675f9d

Please sign in to comment.