Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip creating new image if env is empty #468

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

froody
Copy link
Contributor

@froody froody commented Aug 20, 2024

The docker driver always creates a new container + image in Setup, which for large images causes a long delay during Destroy . For my image with a simple test that checks for the exit code, skipping the new image creation when there is no env saves 3min of execution time:

Before: container-structure-test -v debug test -c -i 0.03s user 0.03s system 0% cpu 3:26.83 total
After: container-structure-test -v debug test -c -i 0.03s user 0.01s system 0% cpu 14.933 total

@thesayyn thesayyn merged commit c35e48d into GoogleContainerTools:main Aug 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants