Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve rendering status e2e validation #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Nov 18, 2022

  • Test the actual API output, instead of using an internal nomos CLI function.
  • Validate source and sync status too, to ensure other errors aren't being populated.
  • Validate the Syncing status condition values too

- Test the actual API output, instead of using an internal nomos
  CLI function.
- Validate source and sync status too, to ensure other errors
  aren't being populated.
- Validate the Syncing status condition values too

Change-Id: I127929f45aa672ddf66dc7db354025c5d1a7cd44
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi by writing /assign @karlkfi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@karlkfi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit-e2e-multi-repo-test-group3 be71932 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@karlkfi
Copy link
Contributor Author

karlkfi commented Nov 18, 2022

This PR is blocked on #260 to make the Syncing condition consistently expose errors.

@karlkfi karlkfi changed the title Improve rendering status e2e validation [WIP] Improve rendering status e2e validation Aug 30, 2023
@mikebz
Copy link
Contributor

mikebz commented Apr 17, 2024

curious if this is still WIP or if it's even relevant. If it is consider closing the PR and keeping the private branch or converting to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants