feat: add MODULE.bazel support to copy.sh plus silent lockless repos #88
+40
−9,875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
Merged
Closed
jjmaestro
force-pushed
the
feat-add-MODULE-to-lock-copy-script-plus-silent-lockless-repos
branch
from
309c9cd
to
55c332a
Compare
See bazelbuild/bazel#20369 While working on refactoring, I kept hitting rebase conflicts due to issues with the MODULE lock. I guess it's because the Bazel version in e2e tests is much lower than the current one with the fix (7.2) but still, I don't think it adds much to have the lock in e2e testing.
PR GoogleContainerTools#73 added the `_resolve` and this breaks the buildozer fix / autofix
It seemed like 75afff9 in GoogleContainerTools#47 added the new locks but as new files, that is, the old ones were left behind.
Add support for MODULE.bazel to the lock script and avoid printing an unnecessary (and annoying 😅) error when building in a "modern repo".
Add a `nolock` attribute to avoid getting annoying DEBUG messages for repos that we explicitly want to run without a lock.
jjmaestro
force-pushed
the
feat-add-MODULE-to-lock-copy-script-plus-silent-lockless-repos
branch
from
55c332a
to
540a7cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Stacked on top of #87
feat: add support for MODULE.bazel to the lock copy.sh script
Add support for
MODULE.bazelto the lock script and avoid printing an unnecessary (and annoying 😅) error when building in a "modern repo".feat: avoid DEBUG messages for lockless repos
Add a
nolockattribute to avoid getting annoyingDEBUGmessages for repos that we explicitly want to run without a lock.