Skip to content

Commit

Permalink
fix: have empty url instead of dash in cloud run service ready event …
Browse files Browse the repository at this point in the history
…if no URL is available
  • Loading branch information
bskaplan committed Sep 12, 2024
1 parent bba880d commit 9b91409
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions pkg/skaffold/deploy/cloudrun/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -345,11 +345,6 @@ func (r *runServiceResource) getTerminalStatus(crClient *run.APIService) (*run.G
}
func (r *runServiceResource) reportSuccess() {
url := r.url
if url == "" {
// a URL may not be present if the default URL is disabled. Use - instead of empty in case anyone is parsing the
// event status
url = "-"
}
eventV2.CloudRunServiceReady(r.path, url, r.latestRevision)
}

Expand Down

0 comments on commit 9b91409

Please sign in to comment.