Skip to content

Commit

Permalink
fix: Set the client DialContext to the connhelper dialer when accessi…
Browse files Browse the repository at this point in the history
…ng an SSH DOCKER_HOST

Summary: Fixes #9484

Test Plan: Tested skaffold over a ssh connection to minikube.

This was tested with and without #9512 in place.
  • Loading branch information
aran committed Sep 8, 2024
1 parent 1d83c09 commit ff855fd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/skaffold/docker/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ func newEnvAPIClient() ([]string, client.CommonAPIClient, error) {
DialContext: helper.Dialer,
},
}
opts = append(opts, client.WithHTTPClient(httpClient), client.WithHost(helper.Host))
opts = append(opts,
client.WithHTTPClient(httpClient),
client.WithHost(helper.Host),
client.WithDialContext(helper.Dialer),
)
} else {
opts = append(opts, client.FromEnv)
}
Expand Down

0 comments on commit ff855fd

Please sign in to comment.