fix: verify hangs if event-logs-file does not exist (#7613) #8961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7613
Description
When running
skaffold verify
with rpc-port and --event-log-file, if the event-log-file references a path to a file where the directory doesn't exist, the command hangs indefinitely. The changes I am proposing ensure that the directories to event-log-file exists before attempting to create the file and dump the logs. The relevant unit tests are also adjusted with the assumption that the directory does not exist.In addition, SaveLastLog seems to follow the same issue, which is also fixed in this PR.
0700 is used since 'execute' permission is needed on the directories. Execute permissions on directory are so that files can be accessed in those nested directories.