Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support metadata to start debugger in wait mode for g… #9105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pkoutsovasilis
Copy link

@pkoutsovasilis pkoutsovasilis commented Sep 30, 2023

Implements #4870:

  • support for starting the respective runtime debugger in "wait" mode for go, python, nodejs, jvm if the container image has the label skaffold.dev/debug-suspend [docker deploy]
  • support for starting the respective runtime debugger in "wait" mode for go, python, nodejs, jvm if the pod template has the annotation the skaffold.dev/debug-suspend [k8s deploy]

@google-cla
Copy link

google-cla bot commented Sep 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 3, 2023
@pkoutsovasilis pkoutsovasilis changed the title feat: support docker image label to start debugger in wait mode for g… feat: support metadata to start debugger in wait mode for g… Oct 3, 2023
@anthonyalayo
Copy link

This is my top desired feature for skaffold. I hope the maintainers can take a look at this soon.

@pkoutsovasilis
Copy link
Author

I am not sure why this PR doesn't get any attention from the maintainers, but I rebased it to resolve the conflicts with main. In my workflow, and I think I am not alone, I need a breakpoint as soon as the first line in main() so such a feature is crucial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants