Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize helm deploy by using goroutines #9451

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Optimize helm deploy by using goroutines #9451

wants to merge 5 commits into from

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Jun 25, 2024 •
edited
Loading

Description

  1. Optimized helm install by using goroutines which reduced deploy time by more than 50%
  2. Added config option to control the concurrency, by default it keeps current logic - sequential installation
  3. Minor fixes

in my case:
before: Deploy completed in 3 minutes 52.351 seconds
after: Deploy completed in 1 minute 57.148 seconds

colleague:
before: Deploy completed in 4 minutes 4.594 seconds
after: Deploy completed in 53.423 seconds

@idsulik idsulik marked this pull request as draft June 25, 2024 08:22
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 25, 2024
@idsulik idsulik force-pushed the helm-deploy-optimization branch 3 times, most recently from 44fb2b8 to d1f1046 Compare June 25, 2024 13:49
@idsulik idsulik marked this pull request as ready for review July 10, 2024 07:20
@idsulik idsulik mentioned this pull request Jul 19, 2024
Merged
@idsulik idsulik marked this pull request as draft August 7, 2024 08:19
@idsulik
feat: Optimize helm deploy by using goroutines
fe40600 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik
added cmd_helper_with_concurrency_support.go
e161fd7 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik
fix(healm): pass errgroup ctx into helm.deployRelease()
842e94c 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik idsulik force-pushed the helm-deploy-optimization branch 2 times, most recently from 6900709 to eb48c18 Compare September 6, 2024 14:52
@idsulik
Added concurrency flag to helm deploy config
454798b 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik
Added log
383b26e 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik idsulik marked this pull request as ready for review September 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@idsulik