Add note to windows installation via poetry #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chyalexcheng
approved these changes
Mar 21, 2024
|
Thank you, Luisa, for locating the source of the issue and adding the note to the docu. Is there a way to set up the build differently for Windows in .github/workflows/build.yml? |
|
Yes, we could try using pip instead of poetry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have been seeing for a while that the build action on windows keeps on failing. I have narrowed down that the issue is with a dependency of tensorflow: tensorflow-io-gcs-filesystem for which the wheels for windows have been somehow forgotten or not published anymore (tensorflow/io#1815 and reports via other channels).
Changes in this PR
Add a note in the documentation recommending to the users to install using pip if poetry cannot resolve the tensorflow dependency.