Unconditional Lookup in Neighbor Table #1797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch perftest |
|
Hi there, this is jenkins continuous integration... |
|
launch perftest |
|
launch jenkins |
havogt
reviewed
Aug 2, 2024
| @@ -86,9 +86,9 @@ namespace gridtools::fn { | |||
| template <class Tag, class Ptr, class Strides, class Domain, class Conn, class Offset> | |||
| GT_FUNCTION constexpr auto horizontal_shift(iterator<Tag, Ptr, Strides, Domain> const &it, Conn, Offset) { | |||
| auto const &table = host_device::at_key<Conn>(it.m_domain.m_tables); | |||
| auto new_index = it.m_index == -1 ? -1 : get<Offset::value>(neighbor_table::neighbors(table, it.m_index)); | |||
| auto new_index = get<Offset::value>(neighbor_table::neighbors(table, std::max(it.m_index, 0))); | |||
There was a problem hiding this comment.
Hmm. For exotic cases the table might not have an entry at 0? E.g. after an origin shift. But maybe we can document in the neighbor_table concept that the 0 index need to exist.
There was a problem hiding this comment.
No idea if there are realistic cases where this happens. And no idea if it makes sense to include this workaround. It’s currently required to have reasonable performance on Daint due to the old CUDA versions. But once we move the performance tests to Alps (we probably will, right?), the GT_PROMISE thing should be good enough, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows better code generations on platforms which don‘t support
GT_PROMISE, that is, CUDA < 12.