feat: First Batch of Translators #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just copied them and did not do a merge, which is not so nice. Furthermore, the tests are not yet there, in my view it makes sense to first have something that can be checked.
Before it was implementewd as a switch, for the case JAX would use the bool overload of XLA. The check for this was now essentially moved inside the function.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage ? 69.23%
=======================================
Files ? 31
Lines ? 1235
Branches ? 251
=======================================
Hits ? 855
Misses ? 314
Partials ? 66 ☔ View full report in Codecov by Sentry. |
egparedes
requested changes
Sep 18, 2024
src/jace/translator/primitive_translators/select_n_translator.py
Outdated
Show resolved
Hide resolved
src/jace/translator/primitive_translators/broadcast_in_dim_translator.py
Outdated
Show resolved
Hide resolved
It is now better confiugured.
Now let's test if it works.
egparedes
approved these changes
Sep 26, 2024
|
|
||
| else: | ||
| dims_to_bcast = [ | ||
| dim for dim in range(out_rank) if in_shape[dim] == 1 and out_shape[dim] != 1 |
There was a problem hiding this comment.
Optional suggestion:
Suggested change
| dim for dim in range(out_rank) if in_shape[dim] == 1 and out_shape[dim] != 1 | |
| dim for dim in range(out_rank) if in_shape[dim] == 1 != out_shape[dim] |
There was a problem hiding this comment.
I did not know that this is possible, however, I do not think that it is very readable the a < x < b is useful but here I do not like it that much,
src/jace/translator/primitive_translators/convert_element_type_translator.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a series of primitive translators, most of them are based on the prototype, with some improvements.
I just copied them over from the development branch, which is not so nice, but was the simplest thing to to without also introducing the other stuff.
It is important that the tests from the development branch were not added, to keep the PR small.
Furthermore, we need something to test, so this PR must go first.
For organizational reasons, the development history of this PR happened to be contained in PR#21.